@corona10, would you mind reviewing this? It's been a while since I've done the module init ref count dances :)

I note that xxlimited_35 creates two objects from the same type spec. I'm not sure if there's a point in doing that.

Thanks, Dong-hee! I'll hold the merge a couple of days to give Petr (or Victor) a chance to review.

Looks good, thanks!
If it was me, instead of create_and_add_type I'd write out the two calls each time: it's a historical module so I'd keep changes to minimal bugfixes. It's OK to showcase how clunky the old API is :)
But that's a minor nit, feel free to merge as is.

Looks good, thanks!
If it was me, instead of create_and_add_type I'd write out the two calls each time: it's a historical module so I'd keep changes to minimal bugfixes. It's OK to showcase how clunky the old API is :)
But that's a minor nit, feel free to merge as is.

I had to ponder a little bit about this; I agree that it's worth it keeping the changes minimal for these modules :)

The point of this module is to show that static types and global variables still work.

The file starts with:

Use this file as a template to start implementing a module that also declares object types.

IMO it should be a show case of the best practice to write a C extension in 2022. Otherwise, people will continue to copy/paste this old code and will propagate static types and other legacy code to their project :-(

If you want to test that the old way to write a C extension, with static types and global variables, still work, IMO it should be another module than this "template".

If you want to test that the old way to write a C extension, with static types and global variables, still work, IMO it should be another module than this "template".

We could adjust the wording in the top of the file, and also rename it to something like xxlegacy.c. But I think this warrants a broader discussion :)

IMO it should be a show case of the best practice to write a C extension in 2022. Otherwise, people will continue to copy/paste this old code and will propagate static types and other legacy code to their project :-(

That's what the xxlimited.c module is :)