Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87260: Update sqlite3 signature docs to reflect actual implementation #93840

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 15, 2022

Resolves #87260

@bedevere-bot bedevere-bot added docs awaiting core review labels Jun 15, 2022
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jun 15, 2022

This is a trivial doc update. I consider it ok to merge it any time soon.

@erlend-aasland erlend-aasland merged commit d318346 into python:main Jun 15, 2022
14 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 15, 2022

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒🤖

@erlend-aasland erlend-aasland deleted the sqlite-signature-discrepancies branch Jun 15, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 15, 2022
…mentation (pythonGH-93840)

Align the docs for the following methods with the actual implementation:

- sqlite3.complete_statement()
- sqlite3.Connection.create_function()
- sqlite3.Connection.create_aggregate()
- sqlite3.Connection.set_progress_handler()
(cherry picked from commit d318346)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 15, 2022

GH-93845 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 15, 2022
…mentation (pythonGH-93840)

Align the docs for the following methods with the actual implementation:

- sqlite3.complete_statement()
- sqlite3.Connection.create_function()
- sqlite3.Connection.create_aggregate()
- sqlite3.Connection.set_progress_handler()
(cherry picked from commit d318346)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 15, 2022

GH-93846 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Jun 15, 2022
…ion (GH-93840)

Align the docs for the following methods with the actual implementation:

- sqlite3.complete_statement()
- sqlite3.Connection.create_function()
- sqlite3.Connection.create_aggregate()
- sqlite3.Connection.set_progress_handler()
(cherry picked from commit d318346)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this issue Jun 15, 2022
…ion (GH-93840)

Align the docs for the following methods with the actual implementation:

- sqlite3.complete_statement()
- sqlite3.Connection.create_function()
- sqlite3.Connection.create_aggregate()
- sqlite3.Connection.set_progress_handler()
(cherry picked from commit d318346)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants