gh-93692: remove redundant "build finished successfully" message from setup.py #93693
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Jun 11, 2022
erlend-aasland
changed the title
|
@tiran, are you fine with this? There is no point in printing this message only if some modules failed to build. |
|
Thanks @erlend-aasland for the PR |
|
Thanks @erlend-aasland for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jun 24, 2022
…up.py (pythonGH-93693) The message was only emitted when the build succeeded _and_ there were missing modules. (cherry picked from commit ab077d1) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
|
GH-94209 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jun 24, 2022
…up.py (pythonGH-93693) The message was only emitted when the build succeeded _and_ there were missing modules. (cherry picked from commit ab077d1) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
|
GH-94210 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this issue
Jun 24, 2022
miss-islington
added a commit
that referenced
this issue
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves #93692