Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42972: Fully support GC for hashlib heap types (GH-26374) #26374

Merged
merged 4 commits into from May 27, 2021
Merged

bpo-42972: Fully support GC for hashlib heap types (GH-26374) #26374

merged 4 commits into from May 27, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 25, 2021 •
edited by miss-islington

@erlend-aasland erlend-aasland requested a review from tiran as a code owner May 25, 2021
@tiran tiran requested a review from gpshead May 26, 2021
tiran
tiran approved these changes May 26, 2021
View changes
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot
Copy link

bedevere-bot commented May 26, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tiran
Copy link
Member

tiran commented May 26, 2021

@pablogsal @erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 26, 2021 •
edited

@pablogsal @erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

I've never seen this, but it does look like an infrastructure issue; the builds/tests did not fail, they were cancelled.

@pablogsal
Copy link
Member

pablogsal commented May 26, 2021

@pablogsal @erlend-aasland Lots of buildbots have failed with Master Shutdown. Is this an infrastructure issues? Can I just restart the buildbots by setting the label again?

That happens when the server restarts with an update, which happened because @vstinner updated the IRC configuration

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@bedevere-bot
Copy link

bedevere-bot commented May 26, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit 49226dd 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 26, 2021
@tiran tiran added the 🤖 automerge PR will be merged once it's been approved and all CI passed label May 27, 2021
@tiran tiran changed the title bpo-42972: Fully support GC for hashlib heap types bpo-42972: Fully support GC for hashlib heap types (GH-26374) May 27, 2021
@tiran tiran merged commit 6ef5ba3 into python:main May 27, 2021
71 of 74 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 27, 2021

Thanks @erlend-aasland for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@tiran tiran removed the 🤖 automerge PR will be merged once it's been approved and all CI passed label May 27, 2021
@bedevere-bot
Copy link

bedevere-bot commented May 27, 2021

GH-26398 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
@miss-islington
bpo-42972: Fully support GC for hashlib heap types (pythonGH-26374)
0f2ec18 
(cherry picked from commit 6ef5ba3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland deleted the bpo-42972/sha256 branch May 27, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 27, 2021

Thanks for reviewing, @gpshead and @tiran! 🙏🏻

miss-islington added a commit that referenced this pull request May 27, 2021
@miss-islington
[3.10] bpo-42972: Fully support GC for hashlib heap types (GH-26374) (G…
4431922 
…H-26398)

(cherry picked from commit 6ef5ba3)


Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

Automerge-Triggered-By: GH:tiran
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@vstinner vstinner mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead

@tiran tiran

Assignees

@gpshead gpshead

@tiran tiran

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@erlend-aasland @bedevere-bot @tiran @pablogsal @miss-islington @gpshead @the-knights-who-say-ni