Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) #26427

Closed
wants to merge 1 commit into from
Closed

[3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) #26427

wants to merge 1 commit into from

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 28, 2021 •
edited by bedevere-bot

(cherry picked from commit 0fa282c)

Co-authored-by: Ken Jin 28750310+Fidget-Spinner@users.noreply.github.com

https://bugs.python.org/issue42972
@Fidget-Spinner @miss-islington
bpo-42972: Fully support GC for _winapi.Overlapped (pythonGH-26381)
19d1225 
(cherry picked from commit 0fa282c)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 28, 2021

@Fidget-Spinner and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 28, 2021
Merged
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 28, 2021

@Fidget-Spinner and @vstinner: Status check is done, and it's a failure ❌ .

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 28, 2021

This time, both win x86 and x64 failed with this single test: test.test_httplib.HTTPSTest.test_local_bad_hostname . I'm investigating.

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented May 28, 2021

Closed, I will manually backport both 0fa282c and #26429 together as one fix (using just either one of them will cause tests to fail)

@miss-islington miss-islington deleted the backport-0fa282c-3.10 branch May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@miss-islington @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot