Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing #21104

Merged
merged 2 commits into from Nov 27, 2022
Merged

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing #21104

merged 2 commits into from Nov 27, 2022

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jun 24, 2020 •
edited by bedevere-bot

eamanu
eamanu approved these changes Jun 24, 2020
View changes
@asottile asottile force-pushed the inspect_signature_simplify branch from 5309efa to 847fd9f Compare Sep 3, 2020
@asottile asottile force-pushed the inspect_signature_simplify branch from 847fd9f to e569169 Compare Nov 2, 2021
@asottile asottile force-pushed the inspect_signature_simplify branch from e569169 to 477c2eb Compare Jul 8, 2022
@asottile asottile force-pushed the inspect_signature_simplify branch from 477c2eb to 83f9192 Compare Aug 5, 2022
@asottile
Copy link
Contributor Author

asottile commented Aug 29, 2022

@1st1 (inspect expert) -- been sitting on this small fix for a few years -- any chance of a review ?

@asottile asottile force-pushed the inspect_signature_simplify branch from 83f9192 to e6eaf8e Compare Oct 5, 2022
@iritkatriel iritkatriel changed the title Simplify routine in inspect.signature parsing remove unused 'invalid' variable in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel changed the title remove unused 'invalid' variable in inspect.signature parsing remove unused 'invalid' value in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel changed the title remove unused 'invalid' value in inspect.signature parsing gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing Nov 27, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 27, 2022
Closed
@iritkatriel iritkatriel merged commit ac115b5 into python:main Nov 27, 2022
13 checks passed
@JelleZijlstra JelleZijlstra mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@eamanu eamanu

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@asottile @iritkatriel @eamanu @the-knights-who-say-ni @ezio-melotti @bedevere-bot @kumaraditya303