Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing #21104

Merged
merged 2 commits into from Nov 27, 2022

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jun 24, 2020

eamanu
eamanu approved these changes Jun 24, 2020
@asottile
Copy link
Contributor Author

asottile commented Aug 29, 2022

@1st1 (inspect expert) -- been sitting on this small fix for a few years -- any chance of a review ?

@asottile asottile force-pushed the inspect_signature_simplify branch from 83f9192 to e6eaf8e Compare Oct 5, 2022
@iritkatriel iritkatriel changed the title Simplify routine in inspect.signature parsing remove unused 'invalid' variable in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel changed the title remove unused 'invalid' variable in inspect.signature parsing remove unused 'invalid' value in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel changed the title remove unused 'invalid' value in inspect.signature parsing gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing Nov 27, 2022
@iritkatriel iritkatriel merged commit ac115b5 into python:main Nov 27, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants