Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 #95964

Merged
merged 4 commits into from Aug 16, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Aug 13, 2022

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Mostly look good. Generally TCL/TK => Tcl/Tk. Also, there are some lines with (assuming unintended) leading white-space, and some with trailing white-space.

Doc/whatsnew/3.11.rst Outdated Show resolved Hide resolved
tiran and others added 2 commits Aug 16, 2022
…957.W9ZZAx.rst

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Two more misspellings of Tcl/Tk, otherwise LGTM.

Misc/rhel7/README.md Outdated Show resolved Hide resolved
Misc/rhel7/README.md Outdated Show resolved Hide resolved
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@tiran tiran changed the title gh-95957: Add instructions for TCL/TK and OpenSSL on RHEL/CentOS 7 gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 Aug 16, 2022
@tiran tiran marked this pull request as ready for review Aug 16, 2022
@tiran tiran merged commit ab4d729 into python:main Aug 16, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 16, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@tiran tiran deleted the gh-95957-tcltk-pc branch Aug 16, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Aug 16, 2022

Sorry @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ab4d72954f3c3fe4bdf51dc6a9cf0ed38f210a68 3.11

@miss-islington
Copy link
Contributor

miss-islington commented Aug 16, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 16, 2022

GH-96022 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2022
…S 7 (pythonGH-95964)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit ab4d729)

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this pull request Aug 18, 2022
…H-95964)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
(cherry picked from commit ab4d729)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants