Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refcounting bug in add_subclass in typeobject.c #93990

Closed
kumaraditya303 opened this issue Jun 18, 2022 · 2 comments
Closed

refcounting bug in add_subclass in typeobject.c #93990

kumaraditya303 opened this issue Jun 18, 2022 · 2 comments
Assignees
@kumaraditya303
Labels
3.10 3.11 3.12 type-bug

Comments

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 18, 2022 •
edited

Currently is does not decref key and ref when the created dict is null.
See #93989
Fidget-Spinner pushed a commit that referenced this issue Jun 19, 2022
@kumaraditya303
GH-93990: fix refcounting bug in add_subclass in typeobject.c (GH…
726448e 
…-93989)
@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jun 19, 2022

Seems like this bug also exists in 3.11 and 3.10. Could you work on the 3.10 backport please? I think it needs to be done manually.

@kumaraditya303
Copy link
Contributor Author

@kumaraditya303 kumaraditya303 commented Jun 19, 2022

Okay, I'll create the backports.

@kumaraditya303 kumaraditya303 self-assigned this Jun 19, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 19, 2022
@kumaraditya303 @miss-islington
pythonGH-93990: fix refcounting bug in add_subclass in `typeobject.…
b957355 
…c` (pythonGH-93989)

(cherry picked from commit 726448e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue Jun 19, 2022
@kumaraditya303
pythonGH-93990: fix refcounting bug in add_subclass in `typeobject.…
c636432 
…c` (pythonGH-93989)
@kumaraditya303 kumaraditya303 added type-bug 3.11 3.10 3.12 labels Jun 19, 2022
miss-islington added a commit that referenced this issue Jun 19, 2022
@miss-islington @kumaraditya303
GH-93990: fix refcounting bug in add_subclass in typeobject.c (GH…
15c8838 
…-93989)

(cherry picked from commit 726448e)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Fidget-Spinner pushed a commit that referenced this issue Jun 19, 2022
@kumaraditya303
GH-93990: fix refcounting bug in add_subclass in typeobject.c (GH…
beba102 
…-93989) (GH-93999)

(cherry picked from commit 726448e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
3.10 3.11 3.12 type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fidget-Spinner @kumaraditya303