Skip to content

Gh-68586: use run_python_until_end in test_capi #102729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2023
Merged

Gh-68586: use run_python_until_end in test_capi #102729

merged 4 commits into from
Apr 9, 2023

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Mar 15, 2023 •
edited by miss-islington
Loading

Co-authored-by: Aidin Gharibnavaz

Automerge-Triggered-By: GH:kumaraditya303

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 15, 2023
Closed
@arhadthedev
Copy link
Member

Could you fix the test please?

======================================================================
ERROR: test_no_FatalError_infinite_loop (test.test_capi.test_misc.CAPITest.test_no_FatalError_infinite_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_capi\test_misc.py", line 76, in test_no_FatalError_infinite_loop
    self.assertEqual(out, '')
  File "D:\a\cpython\cpython\Lib\unittest\case.py", line 873, in assertEqual
    assertion_func(first, second, msg=msg)
  File "D:\a\cpython\cpython\Lib\unittest\case.py", line 863, in _baseAssertEqual
    if not first == second:
           ^^^^^^^^^^^^^^^
BytesWarning: Comparison between bytes and string

kumaraditya303
kumaraditya303 reviewed Apr 9, 2023
View reviewed changes
@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 8317d51 into python:main Apr 9, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@furkanonder @warsaw
pythonGh-68586: use run_python_until_end in test_capi (pythonGH-102729)
af917bf 
Co-authored-by: Aidin Gharibnavaz

Automerge-Triggered-By: GH:kumaraditya303
@vstinner
Copy link
Member

This change is wrong, it introduces a regression: the change removes with support.SuppressCrashReport():. See #106714

I fixed the regression in #107007

@vstinner vstinner mentioned this pull request Jul 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@furkanonder @arhadthedev @miss-islington @vstinner @kumaraditya303 @bedevere-bot @AlexWaygood