Skip to content

gh-102967: Don't pass None to seek(), simply truncate from the current position. #102968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

aaron-fl
Copy link

gh-102967: Don't pass None to seek(), simply truncate from the current position.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Mar 23, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev arhadthedev added the tests Tests in the Lib/test dir label Mar 23, 2023
@AlexWaygood AlexWaygood added stdlib Python modules in the Lib dir and removed tests Tests in the Lib/test dir labels Mar 23, 2023
@aaron-fl
Copy link
Author

Although, as I look at it more. Why would we want the behavior of _SpoofOut.truncate() to differ from the standard implementation? IMO the whole method should be removed. But that might break more things.

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stdlib Python modules in the Lib dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants