gh-99593: Add tests for Unicode C API #99594
Draft
+2,839
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Nov 19, 2022
•
- Issue: Add tests for Unicode C API #99593
|
I have found a bug during testing. I'll extract it into a separate issue later. I'll write the remaining tests after some rest. |
serhiy-storchaka
force-pushed
the
test-unicode-capi3
branch
from
b6bfd11
to
8bf0e29
Compare
vstinner
reviewed
Nov 19, 2022
|
I'll split it on three parts:
|
Are you talking about creating 3 PRs modifying the same files, or do you consider to have separated C and Python files for "higher-level C API corresponding to str methods"? Maybe it's just fine to put most "unicode" tests in "unicode.c" and "unicode.py" tests. |
|
As you suggested, I'll add codecs tests in a separate Python file. The rest of tests will be in All wrappers will be defined in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.