Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-88564: IDLE - fix 2 Edit menu hotkey displays #99743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Nov 24, 2022

On Mac Cocoa, ^+backspace and ^+space were mis-displayed as ^B and ^S. Replace 'backslash' with '' everywhere, just as 'slash', for example, is replaced with '/'. On Mac Cocoa, change 'space' to 'Space', which then displays as 'Space' instead of 'S'. ('Space' is also used for the Mac-specific Emoji & Symbols entry.)

Co-authored by ronaldoussoren

On Mac Cocoa, ^+backspace and ^+space were misdisplayed
as ^B and ^S. Replace 'backslash' with '\' everywhere,
just as 'slash', for example, is replaced with '/'.
On Mac Cocoa, change'space' to 'Space', which then displays
as 'Space' instead of 'S'.  ('Space' is also used for the
Mac-specific Emoji & Symbols entry.)
@terryjreedy
Copy link
Member Author

@ronaldoussoren Besides Windows, I tested this on Catalina by editing installed editor.py. Is the space-> Space fix only needed for Cocoa?

@terryjreedy
Copy link
Member Author

The test failure is hanging for 20 minutes in
test_case_soft_keyword (idlelib.idle_test.test_colorizer.ColorDelegatorTest.test_case_soft_keyword) .
I tested python3.x -m test.test_idle -v on my MacBook Air and got the same failure even with the 2 new lines commented out and with 3.11 and 3.10. I am baffled.
@ned-deily You have any ideas either?

@ronaldoussoren
Copy link
Contributor

This PR does not work for me. If I manually apply the patch to an installed copy of Python 3.12 IDLE crashes when I try to open the Edit menu ("segmentation fault"). Reverting the patch fixes the crash.

The crash report has a stack trace somewhere deep inside system frameworks with Tk on the call stack.

The fix is likely only needed for Cocoa, otherwise we'd have reports from other platforms as well. But that's not something I can test, I can only test using the copy of Tk shipped with out installers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants