Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38823: Clean up refleaks in _tkinter initialization. #17206

Merged
merged 1 commit into from Nov 18, 2019
Merged

bpo-38823: Clean up refleaks in _tkinter initialization. #17206

merged 1 commit into from Nov 18, 2019

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Nov 17, 2019 •
edited by miss-islington

@brandtbucher brandtbucher added skip news type-bug An unexpected behavior, bug, or error labels Nov 17, 2019
taleinat
taleinat approved these changes Nov 18, 2019
View changes
Copy link
Contributor

@taleinat taleinat left a comment

Nice catch! LGTM

@taleinat taleinat added needs backport to 3.7 needs backport to 3.8 🤖 automerge PR will be merged once it's been approved and all CI passed labels Nov 18, 2019
@miss-islington miss-islington merged commit 289cf0f into python:master Nov 18, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2019

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2019

GH-17226 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2019
@brandtbucher @miss-islington
bpo-38823: Clean up refleaks in _tkinter initialization. (pythonGH-17206
cc007ca 
)

https://bugs.python.org/issue38823
(cherry picked from commit 289cf0f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2019

GH-17227 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @brandtbucher
bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206)
9e4d031 
https://bugs.python.org/issue38823
(cherry picked from commit 289cf0f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
miss-islington added a commit that referenced this pull request Nov 18, 2019
@miss-islington @brandtbucher
bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206)
42a4359 
https://bugs.python.org/issue38823
(cherry picked from commit 289cf0f)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@brandtbucher
bpo-38823: Clean up refleaks in _tkinter initialization. (pythonGH-17206
d7ba4a4 
)

https://bugs.python.org/issue38823
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brandtbucher @shihai1991
bpo-38823: Clean up refleaks in _tkinter initialization. (pythonGH-17206
620716d 
)

https://bugs.python.org/issue38823
@brandtbucher brandtbucher deleted the _tkinter branch Jul 21, 2022
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brandtbucher @miss-islington @bedevere-bot @taleinat @the-knights-who-say-ni