Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings found by clang #102711

Closed
parheliamm opened this issue Mar 15, 2023 · 1 comment
Closed

Warnings found by clang #102711

parheliamm opened this issue Mar 15, 2023 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@parheliamm
Copy link
Contributor

parheliamm commented Mar 15, 2023 •
edited by bedevere-bot

During build python via clang-15, the below warnings were found:

/home/lge/rpmbuild/BUILD/Python-3.10.9/Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void
/home/lge/rpmbuild/BUILD/Python-3.10.9/Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Above warnings exist from 3.9.x to the latest main branch.

Linked PRs
@parheliamm parheliamm added the type-bug An unexpected behavior, bug, or error label Mar 15, 2023
@bedevere-bot bedevere-bot mentioned this issue Mar 15, 2023
Merged
parheliamm added a commit to parheliamm/cpython that referenced this issue Mar 15, 2023
@parheliamm
pythonGH-102711: Fix -Wstrict-prototype warnings found by clang
2f1e655 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.
Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
@bedevere-bot bedevere-bot mentioned this issue Mar 28, 2023
Merged
ambv pushed a commit that referenced this issue Mar 28, 2023
@parheliamm
GH-102711: Fix warnings found by clang (#102712)
7703def 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
@bedevere-bot bedevere-bot mentioned this issue Mar 28, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 28, 2023
@parheliamm @miss-islington
pythonGH-102711: Fix warnings found by clang (pythonGH-102712)
6fc5042 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

(cherry picked from commit 7703def)

Co-authored-by: Chenxi Mao <chenxi.mao@suse.com>
Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 28, 2023
@parheliamm @miss-islington
pythonGH-102711: Fix warnings found by clang (pythonGH-102712)
8210ff1 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

(cherry picked from commit 7703def)

Co-authored-by: Chenxi Mao <chenxi.mao@suse.com>
Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 28, 2023
@parheliamm @miss-islington
pythonGH-102711: Fix warnings found by clang (pythonGH-102712)
17db875 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

(cherry picked from commit 7703def)

Co-authored-by: Chenxi Mao <chenxi.mao@suse.com>
Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
ambv pushed a commit that referenced this issue Mar 28, 2023
@miss-islington @parheliamm
[3.11] GH-102711: Fix warnings found by clang (GH-102712) (#103075)
abd6e97 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

(cherry picked from commit 7703def)

Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
Co-authored-by: Chenxi Mao <chenxi.mao@suse.com>
ambv pushed a commit that referenced this issue Mar 28, 2023
@miss-islington @parheliamm
[3.10] GH-102711: Fix warnings found by clang (GH-102712) (#103076)
aae84a0 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

(cherry picked from commit 7703def)

Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
Co-authored-by: Chenxi Mao <chenxi.mao@suse.com>
@ambv
Copy link
Contributor

ambv commented Mar 28, 2023

Fixed in 3.10 - 3.12. Thanks! ✨ 🍰 ✨

@ambv ambv closed this as completed Mar 28, 2023
RethinkMatze pushed a commit to RethinkMatze/cpython that referenced this issue Mar 30, 2023
@parheliamm @RethinkMatze
pythonGH-102711: Fix warnings found by clang (python#102712)
a2493f8 
There are some warnings if build python via clang:

Parser/pegen.c:812:31: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_clear_memo_statistics()
                              ^
                               void

Parser/pegen.c:820:29: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
_PyPegen_get_memo_statistics()
                            ^
                             void

Fix it to make clang happy.

Signed-off-by: Chenxi Mao <chenxi.mao@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ambv @parheliamm