[Serializer] Add XmlEncoder::CDATA_WRAPPING context option
#49893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Work
Feature
Serializer
Status: Needs Review
and removed
Status: Needs Work
labels
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot
changed the title
3 tasks
AndoniLarz
changed the title
|
Failing checks seem unrelated to my changes |
mtarld
requested changes
Apr 5, 2023
|
I tested the changes from the PR and they work like a charm 👍 |
nicolas-grekas
changed the title
XmlEncoder::ENABLE_CDATA_WRAPPING context option
nicolas-grekas
changed the title
XmlEncoder::ENABLE_CDATA_WRAPPING context optionXmlEncoder::CDATA_WRAPPING context option
nicolas-grekas
force-pushed
the
ticket_26128-add-xml-encoder-cdata-wrapping-opt-out
branch
from
7b9af66 to
c80761e
Compare
nicolas-grekas
force-pushed
the
ticket_26128-add-xml-encoder-cdata-wrapping-opt-out
branch
from
c80761e to
049982d
Compare
nicolas-grekas
approved these changes
Oct 11, 2023
|
Thank you @AndoniLarz. |
This was referenced Oct 21, 2023
Merged
Merged
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 16, 2024
…CDATA wrapping opt-out context option (AndoniLarz) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Serializer] Add documentation about a new XmlEncoder CDATA wrapping opt-out context option Add documentation of symfony/symfony#49893 which has been merged in 6.4. TODO : - [x] Fix conflicts (by rebasing) - [x] Edit the context option name (`enable_cdata_wrapping` => `cdata_wrapping`) - [x] Wait for the reviews Commits ------- 705d5d2 [Serializer] Add documentation about a new XmlEncoder CDATA wrapping opt-out context option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage example :
will output
instead of
As stated in the following comment from PHP.net : PHP automatically handles the escape when calling
DOMDocument::createTextNodewhich is done in ::appendText.::appendTextis always called ifXmlEncoder::CDATA_WRAPPING => false.Questions:
callable(string $val): bool)'and"might also be escaped. Based on this should we instead provide a list of characters to escape/wrap ? (currently it would be set to['<', '>', '&'])