Tag: v1.5.1
-
docs(guide/Component Router): adjust the order in the menu
Component Router should come after the menu topic Components as Components should be understood first before Component Routers. This made it easier to read the Component Routers topic. Closes #14214
-
chore: streamline issue/pr templates
Narretz committedMar 10, 2016 Removes the bullet points and makes all prompts bold, which should make it easier to see which content has been added by the issue author
-
docs(changelog, migration): add BC notice for allowed form name values
Narretz committedFeb 29, 2016
-
docs(errorDisplay): encode `<` and `>` in error messages
When an error message contains an HTML string (e.g. `$location:nobase` containing `<base>`), it was interpreted as a literal HTML element, instead of text. Error messages are not expected to render as HTML, but we still need to use `.html()` in `errorDisplay`, so that the links created by `errorLinkFilter` are properly displayed. This commit solves this issue by replacing `<`/`>` with `<`/`>`. Related to #14016.
-
-
refactor($compile): move setup/get controller methods out of the comp…
…ile node closure Closes #13427
-
fix(ngOptions): always set the 'selected' attribute for selected options
We don't set selected property / attribute on options that are already selected. That happens for example if the browser has automatically selected the first option in a select. In that case, the selected property is set automatically, but the selected attribute is not. This doesn't impact the functionality of the select, but it can be problematic if option elements are selected with `option[selected]` in tests. Closes #14115 Closes #14125
-
docs(guide/Interpolation): fix code example
The function getForm is receiving a variable from the view and should be using that. Closes #14142
-
docs(guide/Services): improve the code example
A factory that doesn't return anything is a bad example of a factory. Closes #14139
-
docs(guide/interpolation): make some minor improvements, add info
Narretz committedFeb 28, 2016 - highlight that interpolation inside expressions is bad practice - add info about type attr in buttons in IE
-
refactor($compile): Create non-descriptive comments when debugInfoEna…
…bled is false When debugInfoEnabled is `false` when comments generated by transclusions, ngIf, ngRepeat and ngSwitch will not contain any information about the directive nor the expression associated with it. Closes: #8722
-
fix(ngRoute): allow `ngView` to be included in an asynchronously load…
…ed template During it's linking phase, `ngView` relies on the info provided in `$route.current` for instantiating the initial view. `$route.current` is set in the callback of a listener to `$locationChangeSuccess`, which is registered during the instantiation of the `$route` service. Thus, it is crucial that the `$route` service is instantiated before the initial `$locationChangeSuccess` is fired. Since `ngView` declares `$route` as a dependency, the service is instantiated in time if `ngView` is present during the initial load of the page. Yet, in cases where `ngView` is included in a template that is loaded asynchronously (e.g. in another directive's template), the directive factory might not be called soon enough for `$route` to be instantiated before the initial `$locationChangeSuccess` event is fired. This commit fixes it, by always instantiating `$route` up front, during the initialization phase. Fixes #1213 Fixes #6812 Closes #14088
-
docs(guide/security): provide more information about security features
Thanks to Jim Manico for help updating this guide.
-
fix(ngMock): don't break if `$rootScope.$destroy()` is not a function
Previously, `angular-mocks` was calling `$rootScope.$destroy()` after each test as part of it's cleaning up, assuming that it was always available. This could break if `$rootScope` was mocked and the mocked version didn't provide the `$destroy()` method. This commit prevents the error by first checking that `$rootScope.$destroy` is present. Fixes #14106 Closes #14107
-
feat($compile): add custom annotations to the controller
This means that we can access these annotations, such as `$routeConfig` and `$routerCanActivate` without highjacking the `ng` module. Closes #14114