Skip to content

build: continue publishing @angular/bazel snapshot builds #49583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: continue publishing @angular/bazel snapshot builds #49583

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

We are no longer publishing Angular Bazel to npm, but we are still using it in the
components repo. We should still publish it to benefit from e.g. the APF v16 changes.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 24, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 24, 2023
@devversion
build: continue publishing @angular/bazel snapshot builds
7e44447 
We are no longer publishing Angular Bazel to npm, but we are still
using it in the components repo. We should still publish it to
benefit from e.g. the APF v16 changes.
@devversion devversion requested a review from alan-agius4 March 24, 2023 15:44
@devversion devversion force-pushed the build-still-publish-bazel-snapshots branch from d878a50 to 7e44447 Compare March 24, 2023 15:44
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 24, 2023
@devversion
Copy link
Member Author

cc. @josephperrott since we didn't move Angular Bazel into dev-infra yet

josephperrott
josephperrott approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Good call

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 24, 2023
@devversion devversion marked this pull request as ready for review March 24, 2023 16:36
@atscott
Copy link
Contributor

atscott commented Mar 24, 2023

This PR was merged into the repository by commit 71def16.

@atscott atscott closed this in 71def16 Mar 24, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @atscott @josephperrott @alan-agius4