Meta issue for cleaning up import system cruft #97850

warsaw · 2022-10-04T22:12:32Z

This is a meta issue tracking all the things that need to be cleaned up in the import system. From removing long deprecated APIs to migrating internal access to __spec__, we'll have several task lists for each related set of clean ups.

@brettcannon @ericsnowcurrently for visibility.

Removing deprecated APIs

Over in What's New for Python 3.11 there's a long list of things that have been deprecated long enough that they can be removed in Python 3.12. Here's that task list for tracking purposes. Watch for linked PRs (maybe one big one or many small ones -- we'll see!).

@brettcannon @ericsnowcurrently for visibility.

Update docs

Make sure examples and details from PEP 302 are covered in the importlib docs (/cc @Yhg1s )
Remove https://docs.python.org/3/reference/import.html#open-issues (PR)
It would be really nice to have a diagram.
(import_machinery.rst) how about a section devoted just to the attributes of modules and packages, perhaps expanding upon or supplanting the related entries in the data model reference page?
runpy, pkgutil, et al in the library manual should all get “See Also” links at the top pointing to the new import system section.
Add more explanation regarding the different ways in which __main__ is initialized?
Add more info on __main__ quirks/pitfalls (i.e. copy from PEP 395).

Missing deprecations

Here's a list of related APIs that have not yet been deprecated, but should be. We'll deprecate them in 3.12 and remove them in 3.14.

pkgutil.find_loader()
pkgutil.get_loader() (or it needs to be reimplemented to not use find_loader())

PR: gh-97850: Deprecate find_module and get_module in pkgutil #98520

The text was updated successfully, but these errors were encountered:

sobolevn · 2022-10-05T08:43:40Z

I've removed importlib.utils.set_loader, importlib.utils.set_package, and
importlib.utils.module_for_loader from importlib.utils in #97898 🎉

Remove all known instances of module_repr()

Tracking in python#97850 instead.

* main: (66 commits) pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879) docs(typing): add "see PEP 675" to LiteralString (python#97926) pythongh-97850: Remove all known instances of module_repr() (python#97876) I changed my surname early this year (python#96671) pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768) pythongh-91539: improve performance of get_proxies_environment (python#91566) build(deps): bump actions/stale from 5 to 6 (python#97701) pythonGH-95172 Make the same version `versionadded` oneline (python#95172) pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073) pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774) pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896) pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383) pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759) pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251) pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662) pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644) pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756) pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778) pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826) Add re.VERBOSE flag documentation example (python#97678) ...

…97935) Remove the open issues section from the import reference Tracking in #97850 instead.

…nce (pythonGH-97935) Remove the open issues section from the import reference Tracking in python#97850 instead. (cherry picked from commit f8edc6f) Co-authored-by: Brett Cannon <brett@python.org>

…H-97935) Remove the open issues section from the import reference Tracking in #97850 instead. (cherry picked from commit f8edc6f) Co-authored-by: Brett Cannon <brett@python.org>

…ence (GH-97935) (GH-97994) Remove the open issues section from the import reference Tracking in #97850 instead. (cherry picked from commit f8edc6f) Co-authored-by: Brett Cannon <brett@python.org> Automerge-Triggered-By: GH:brettcannon

* main: fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965) pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990) pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992) pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974) pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785) pythongh-86482: Document assignment expression need for ()s (python#23291) pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949) pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)

* gh-97850: Remove deprecated functions from `importlib.utils` * Rebase and remove `set_package` from diff

* main: (53 commits) pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926) pythonGH-88050: fix race in closing subprocess pipe in asyncio (python#97951) pythongh-93738: Disallow pre-v3 syntax in the C domain (python#97962) pythongh-95986: Fix the example using match keyword (python#95989) pythongh-97897: Prevent os.mkfifo and os.mknod segfaults with macOS 13 SDK (pythonGH-97944) pythongh-94808: Cover `PyUnicode_Count` in CAPI (python#96929) pythongh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (python#96610) pythongh-95691: Doc BufferedWriter and BufferedReader (python#95703) pythonGH-88968: Add notes about socket ownership transfers (python#97936) pythongh-96865: [Enum] fix Flag to use CONFORM boundary (pythonGH-97528) pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879) docs(typing): add "see PEP 675" to LiteralString (python#97926) pythongh-97850: Remove all known instances of module_repr() (python#97876) I changed my surname early this year (python#96671) pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768) pythongh-91539: improve performance of get_proxies_environment (python#91566) build(deps): bump actions/stale from 5 to 6 (python#97701) pythonGH-95172 Make the same version `versionadded` oneline (python#95172) pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073) pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774) ...

* main: pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996) pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984) fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965) pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990) pythongh-97850: Remove the open issues section from the import reference (python#97935) Docs: pin sphinx-lint (pythonGH-97992) pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591) Add Pynche's move to the What's new in 3.11 (python#97974) pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785) pythongh-86482: Document assignment expression need for ()s (python#23291) pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)

* main: pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803) pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005) Docs: Fix backtick errors found by sphinx-lint (python#97998) pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898) Remove extra spaces in custom openSSL documentation. (python#93568) pythonGH-90985: Revert "Deprecate passing a message into cancel()" (python#97999)

…7876) Remove all known instances of module_repr()

…nce (python#97935) Remove the open issues section from the import reference Tracking in python#97850 instead.

…ython#97898) * pythongh-97850: Remove deprecated functions from `importlib.utils` * Rebase and remove `set_package` from diff

sobolevn · 2022-10-21T13:26:56Z

I've created a PR: #98520
to complete these two tasks:

pkgutil.find_loader()

pkgutil.get_loader() (or it needs to be reimplemented to not use find_loader())

brettcannon · 2022-10-21T18:49:28Z

FYI #64138 is a tracking issue for pkgutil all up.

…ence (GH-97935) (GH-97994) Remove the open issues section from the import reference Tracking in #97850 instead. (cherry picked from commit f8edc6f) Co-authored-by: Brett Cannon <brett@python.org> Automerge-Triggered-By: GH:brettcannon

warsaw changed the title ~~Task list for cleaning up import system cruft for Python 3.12~~ Meta issue for cleaning up import system cruft Oct 4, 2022

bedevere-bot mentioned this issue Oct 5, 2022

gh-97850: Remove all known instances of module_repr() #97876

Merged

warsaw added the expert-importlib label Oct 5, 2022

warsaw self-assigned this Oct 5, 2022

sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 5, 2022

pythongh-97850: Remove deprecated functions from importlib.utils

cb4e97c

bedevere-bot mentioned this issue Oct 5, 2022

gh-97850: Remove deprecated functions from importlib.utils #97898

Merged

warsaw added a commit that referenced this issue Oct 5, 2022

gh-97850: Remove all known instances of module_repr() (#97876)

5dc3599

Remove all known instances of module_repr()

brettcannon self-assigned this Oct 5, 2022

brettcannon added a commit to brettcannon/cpython that referenced this issue Oct 5, 2022

Remove the open issues section from the import reference

0591f9f

Tracking in python#97850 instead.

brettcannon mentioned this issue Oct 5, 2022

gh-97850: Remove the open issues section from the import reference #97935

Merged

sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 5, 2022

pythongh-97850: Remove deprecated functions from importlib.utils

b3a8ee6

miss-islington mentioned this issue Oct 6, 2022

[3.11] gh-97850: Remove the open issues section from the import reference (GH-97935) #97994

Merged

brettcannon added a commit that referenced this issue Oct 6, 2022

gh-97850: Remove the open issues section from the import reference (#…

f8edc6f

…97935) Remove the open issues section from the import reference Tracking in #97850 instead.

miss-islington mentioned this issue Oct 6, 2022

[3.10] gh-97850: Remove the open issues section from the import reference (GH-97935) #97995

Merged

warsaw pushed a commit that referenced this issue Oct 7, 2022

gh-97850: Remove deprecated functions from importlib.utils (#97898)

27025e1

* gh-97850: Remove deprecated functions from `importlib.utils` * Rebase and remove `set_package` from diff

warsaw mentioned this issue Oct 7, 2022

Remove more deprecated importlib APIs from Python 3.12 #98040

Open

mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022

pythongh-97850: Remove all known instances of module_repr() (python#9…

0aca8ca

…7876) Remove all known instances of module_repr()

mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022

pythongh-97850: Remove the open issues section from the import refere…

9ffbad4

…nce (python#97935) Remove the open issues section from the import reference Tracking in python#97850 instead.

mpage pushed a commit to mpage/cpython that referenced this issue Oct 11, 2022

pythongh-97850: Remove deprecated functions from importlib.utils (p…

04a52de

…ython#97898) * pythongh-97850: Remove deprecated functions from `importlib.utils` * Rebase and remove `set_package` from diff

sobolevn added a commit to sobolevn/cpython that referenced this issue Oct 21, 2022

pythongh-97850: Deprecate find_module and get_module in pkgutil

b7de6df

bedevere-bot mentioned this issue Oct 21, 2022

gh-97850: Deprecate find_module and get_module in pkgutil #98520

Open

Meta issue for cleaning up import system cruft #97850

Meta issue for cleaning up import system cruft #97850

warsaw commented Oct 4, 2022 •

edited by FFY00

sobolevn commented Oct 5, 2022

sobolevn commented Oct 21, 2022

brettcannon commented Oct 21, 2022

Meta issue for cleaning up import system cruft #97850

Meta issue for cleaning up import system cruft #97850

Comments

warsaw commented Oct 4, 2022 • edited by FFY00

Removing deprecated APIs

Update docs

Missing deprecations

sobolevn commented Oct 5, 2022

sobolevn commented Oct 21, 2022

brettcannon commented Oct 21, 2022

warsaw commented Oct 4, 2022 •

edited by FFY00