gh-87092: expose the compiler's codegen to python for unit tests #99111
Conversation
iritkatriel
added
tests
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
iritkatriel
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
| @@ -40,6 +40,13 @@ extern int _PyAST_Optimize( | |||
| _PyASTOptimizeState *state); | |||
|
|
|||
| /* Access compiler internals for unit testing */ | |||
|
|
|||
| PyAPI_FUNC(PyObject*) _PyCompile_CodeGen( | |||
There was a problem hiding this comment.
Does this (or the other functions) need to be an API function?
There was a problem hiding this comment.
Can _testinternalcapi import them otherwise?
There was a problem hiding this comment.
I think so, that why it has "internal" in the name.
It defines Py_BUILD_CORE_BUILTIN
There was a problem hiding this comment.
It doesn't seem to work:
[ERROR] _testinternalcapi failed to import: dlopen(/Users/iritkatriel/src/cpython-654/build/lib.macosx-13.0-x86_64-3.12-pydebug/_testinternalcapi.cpython-312d-darwin.so, 0x0002): symbol not found in flat namespace '__PyCompile_CodeGen'
There was a problem hiding this comment.
I'll merge this PR now, it's getting into merge conflicts all the time. We can remove these from the API later if it's possible.
With this we can run just codegen from python, and get the un-optimized instruction sequence for an AST.