Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-83004: Harden winsound init #103385

Merged
merged 3 commits into from Apr 9, 2023
Merged

gh-83004: Harden winsound init #103385

merged 3 commits into from Apr 9, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 8, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Apr 8, 2023
Open
@erlend-aasland erlend-aasland marked this pull request as ready for review April 8, 2023 21:00
@erlend-aasland erlend-aasland requested a review from a team as a code owner April 8, 2023 21:00
@erlend-aasland erlend-aasland mentioned this pull request Apr 8, 2023
Open
hauntsaninja
hauntsaninja reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Should we decref module in the error case?

@kumaraditya303 @erlend-aasland
Update PC/winsound.c
df65947 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 9, 2023 •
edited

Thanks for the review, Kumar & Shantanu!

@erlend-aasland erlend-aasland merged commit 6d97e52 into python:main Apr 9, 2023
15 checks passed
@erlend-aasland erlend-aasland deleted the cleanup-winsound branch April 9, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@python/windows-team windows-team

@zooba zooba

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlend-aasland @hauntsaninja @kumaraditya303 @bedevere-bot