bpo-39671: Clarify semantics of asyncio.wait with FIRST_COMPLETED/EXCEPTION #21918
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a couple (potential) bugs due to the assumption that when using `return_when=FIRST_COMPLETED` or `return_when=FIRST_EXCEPTION` the `done` set would contain only the first completed future. I did however become suspicious that this may not be the case, and indeed it is not. I wouldn't claim that this behavior is inconsistent with how the function is already documented, but I think it would be helpful to clarify this.
|
This seems to be related to https://bugs.python.org/issue39671 |
|
Ah, I didn't see that issue. Thanks for pointing it out. |
embray
changed the title
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I had a couple (potential) bugs due to the assumption that when using
return_when=FIRST_COMPLETEDorreturn_when=FIRST_EXCEPTIONthedoneset would contain only the first completed future.I did however become suspicious that this may not be the case, and indeed it is not. I wouldn't claim that this behavior is inconsistent with how the function is already documented, but I think it would be helpful to clarify this.
https://bugs.python.org/issue39671