gh-104273: Remove redundant len() calls in argparse function #104274
Merged
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
buraksaler
commented
May 7, 2023
•
buraksaler
commented
- Issue: argparse: remove redundant len() #104273
This comment has been hidden.
This comment has been hidden.
|
All commit authors signed the Contributor License Agreement. |
terryjreedy
approved these changes
May 7, 2023
|
Burak, I am merging this because to me it makes the code a bit clearer. Redundant expressions can raise the question of whether, in this case, indent was changed so that its len could change. I otherwise would agree with 2 other core developers that this does not do enough to be worth merging. So next time, please about a meatier improvement. Or find an actual bug issue. |
terryjreedy
changed the title
|
@terryjreedy thank you for the feedback. I'll try my best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.