gh-76377: Rewrite plistlib with functional style. #4671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up most loadings and savings around 10%. Saving with XML format has been sped up to 2 times.
auvipy
approved these changes
May 21, 2019
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
arhadthedev
changed the title
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
arhadthedev
added
3.13
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
bswck
reviewed
Nov 11, 2024
Comment on lines
+327
to
+331
| end_handlers['true'] = lambda: add_object(True) | ||
| end_handlers['false'] = lambda: add_object(False) | ||
| end_handlers['integer'] = lambda: add_object(int(get_data())) | ||
| end_handlers['real'] = lambda: add_object(float(get_data())) | ||
| end_handlers['string'] = lambda: add_object(get_data()) |
There was a problem hiding this comment.
Do you think we could use functools.partials here (where arguments are constants)?
bswck
reviewed
Nov 11, 2024
There was a problem hiding this comment.
What an awesome PR.
@serhiy-storchaka what is the state of this PR? Can we still somehow make it through?
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
|
@serhiy-storchaka rebase? |
github-actions
bot
removed
the
stale
auvipy
suggested changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up most loadings and savings around 10%. Saving
with XML format has been sped up to 2 times.
https://bugs.python.org/issue32196