New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-103247: add tearDown
to test_loader
and clear module cache
#104226
Conversation
sunmy2019
commented
May 6, 2023
•
edited by bedevere-bot
edited by bedevere-bot
- Issue: test_pickle/test_pickletools fail when running tests sequentially. #103247
tearDown
and clear module cachetearDown
to test_loader
and clear module cache
I was able to repro the reported failure on main, and confirmed this PR fixes it. I'm not sure adding the in any case, I also confirmed that just adding the context manager to |
Adding this is proposed by @FFY00. And I am neutral about it. |
I think you are correct, adding both is unnecessary.
I prefer the former since it's a test case. Thus, I will remove this safe net for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @sunmy2019 for the PR, and @brettcannon for merging it |
GH-104345 is a backport of this pull request to the 3.11 branch. |
…xtensions/test_loader.py (pythonGH-104226) (cherry picked from commit 22f3425c3d3d896be0917d80d55e8abb08d99b18) Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>