Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46289: Make conversion of FormattedValue not optional on ASDL #30467

Merged
merged 1 commit into from Jan 7, 2022
Merged

bpo-46289: Make conversion of FormattedValue not optional on ASDL #30467

merged 1 commit into from Jan 7, 2022

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Jan 7, 2022 •
edited by miss-islington

https://bugs.python.org/issue46289

Automerge-Triggered-By: GH:isidentical

@isidentical isidentical added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jan 7, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jan 7, 2022

@isidentical: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d382f7e into python:main Jan 7, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jan 7, 2022

Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2022
@isidentical @miss-islington
bpo-46289: Make conversion of FormattedValue not optional on ASDL (py…
89dffc3 
…thonGH-30467)

Automerge-Triggered-By: GH:isidentical
(cherry picked from commit d382f7e)

Co-authored-by: Batuhan Taskaya <batuhan@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jan 7, 2022

GH-30469 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jan 7, 2022
@miss-islington @isidentical
bpo-46289: Make conversion of FormattedValue not optional on ASDL (GH…
bea3f42 
…-30467)

Automerge-Triggered-By: GH:isidentical
(cherry picked from commit d382f7e)

Co-authored-by: Batuhan Taskaya <batuhan@python.org>
@cdce8p cdce8p mentioned this pull request Apr 22, 2022
Open
3 tasks
@hauntsaninja hauntsaninja mentioned this pull request May 9, 2022
Merged
@hauntsaninja hauntsaninja mentioned this pull request May 19, 2022
Closed
@hauntsaninja hauntsaninja mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@isidentical @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni