GH-103906: Remove immortal refcounting in the interpreter #103909
Merged
+476
−516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
brandtbucher
commented
Apr 26, 2023
•
brandtbucher
commented
- Issue: Avoid reference counting operations on None, True, False in the interpreter #103906
brandtbucher
added
performance
hauntsaninja
approved these changes
Apr 27, 2023
sunmy2019
reviewed
Apr 27, 2023
| } | ||
| else if (Py_IsFalse(cond)) { | ||
| _Py_DECREF_NO_DEALLOC(cond); | ||
| if (Py_IsFalse(cond)) { |
There was a problem hiding this comment.
Will this cause a performance change, since formerly IsTrue then IsFalse, now IsFalse then IsTrue
Though this comparison is lightweight.
There was a problem hiding this comment.
Honestly, I doubt it.
brandtbucher
added
the
|
If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
sobolevn
reviewed
Apr 27, 2023
|
@sobolevn possibly, but it's best left to a different PR. In many places it's unlikely to make a significant difference, so it might not be worth the churn to make the change everywhere. |
|
Annoyingly, perf impact is neutral. However, it appears that the results are being pulled way down by a couple of known unstable benchmarks that should be unaffected by this change. I might try running them again tonight, just to see. (I still think this is worth doing, though, as it clearly removes unnecessary work from many hot code paths.) |
markshannon
approved these changes
May 12, 2023
|
I noticed one more opportunity like this: in the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.