Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41088: Extend the AST Validator to validate all identifiers #21069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Jun 23, 2020

@@ -21,7 +21,7 @@ static int validate_stmt(stmt_ty);
static int validate_expr(expr_ty, expr_context_ty);

static int
validate_name(PyObject *name)
validate_name(const char* owner, PyObject *name)
{
Copy link
Member

@iritkatriel iritkatriel Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In validate_name owner is the first arg and in validate_import_names it is the last arg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants