GH-69695: Update PyImport_ImportModule description
#103836
Conversation
patenaud
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
AA-Turner
changed the title
PyImport_ImportModule description
| import of a module doesn't leave the module in :data:`sys.modules`. | ||
|
|
||
| This function always uses absolute imports. | ||
| This is a wrapper around :c:func:`PyImport_Import()` which takes a ``const char *`` as an argument instead of a ``PyObject *``. |
There was a problem hiding this comment.
You could maybe use c:expr syntax here?:
| This is a wrapper around :c:func:`PyImport_Import()` which takes a ``const char *`` as an argument instead of a ``PyObject *``. | |
| This is a wrapper around :c:func:`PyImport_Import()` which takes a | |
| :c:expr:`const char *` as an argument instead of a ``PyObject *``. |
Regardless of that please wrap the line, i.e.:
| This is a wrapper around :c:func:`PyImport_Import()` which takes a ``const char *`` as an argument instead of a ``PyObject *``. | |
| This is a wrapper around :c:func:`PyImport_Import()` which takes a | |
| ``const char *`` as an argument instead of a ``PyObject *``. |
A
There was a problem hiding this comment.
Couldn't the :c:expr: use also apply to PyObject *?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
import.rst file updated
gh-69695: PyImport_ImportModule description updated