gh-79037: Make the repr of lambda containing the signature and body expression. #9647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
reviewed
Oct 5, 2018
| if (!exprstr) { | ||
| return 0; | ||
| } | ||
| name = PyUnicode_FromFormat("<%U>", exprstr); |
There was a problem hiding this comment.
Before this, add C equivalent of, say,
if len(exprstr) > 36: exprstr = exprstr[0:36] + ' ...'
iritkatriel
requested changes
Nov 25, 2022
|
When you're done making the requested changes, leave the comment: |
hauntsaninja
changed the title
furkanonder
approved these changes
May 13, 2023
There was a problem hiding this comment.
LGTM. It would be extremely beneficial for Lambda's repr to include the signature and body, particularly for debugging. @serhiy-storchaka Could you resolve the conflicts?
terryjreedy
requested changes
May 14, 2023
| @@ -107,6 +107,18 @@ Other Language Changes | |||
| and :keyword:`return` statements. | |||
| (Contributed by David Cuthbert and Jordan Chapman in :issue:`32117`.) | |||
|
|
|||
| * The repr and the name of :keyword:`lambda` functions will now contain | |||
There was a problem hiding this comment.
The whatsnew entry must be added to the current main file, not the 3.8 file.
| @@ -0,0 +1 @@ | |||
| The repr of lambda now contains the signature and body expression. | |||
There was a problem hiding this comment.
Suggested change
| The repr of lambda now contains the signature and body expression. | |
| Add signature and body expression to the repr of lambda. |
I think that this would also be a better PR title.
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34856