[FrameworkBundle] Display aliases in debug:container command
#47427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlslew
changed the title
jlslew
force-pushed
the
feature/39381
branch
from
b3b92d9 to
75a4853
Compare
OskarStark
changed the title
debug:container command
94noni
approved these changes
Feb 8, 2023
carsonbot
changed the title
debug:container commanddebug:container command
|
nice addition it will help in dev a lot |
fabpot
requested changes
Feb 10, 2023
Will do |
jlslew
force-pushed
the
feature/39381
branch
from
75a4853 to
5448ba9
Compare
fabpot
approved these changes
Sep 13, 2023
carsonbot
changed the title
debug:container commanddebug:container command
nicolas-grekas
force-pushed
the
feature/39381
branch
from
eb3b4e9 to
c5a6d4a
Compare
There was a problem hiding this comment.
I rebased the PR but there are some failures to fix.
@jlslew could you please have a look?
| 'id' => (string) $value, | ||
| ]; | ||
| } | ||
| } catch (\Throwable $throwable) { |
There was a problem hiding this comment.
can this be more specific? what kind of exceptions can we expect here?
94noni
approved these changes
Oct 25, 2023
fabpot
reviewed
Feb 3, 2024
| @@ -11,6 +11,7 @@ CHANGELOG | |||
| * Add `DomCrawlerAssertionsTrait::assertAnySelectorTextContains(string $selector, string $text)` | |||
| * Add `DomCrawlerAssertionsTrait::assertAnySelectorTextSame(string $selector, string $text)` | |||
| * Add `DomCrawlerAssertionsTrait::assertAnySelectorTextNotContains(string $selector, string $text)` | |||
| * Display aliases in debug:container command | |||
There was a problem hiding this comment.
Suggested change
| * Display aliases in debug:container command | |
| * Display aliases in `debug:container` command |
|
@jlslew up to resume this PR? |
|
if no news for @jlslew I would be glad to take over his initial work, as this PR is mostly finished and can add great value imho |
|
@94noni Please, can you take over this PR? |
|
@94noni you can take over the PR, thanks. |
|
PR landed here #54459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
bin/console debug:container cache.app --show-arguments --with-aliases --format FORMATon a symfony/skeleton:6.2 project{ "alias": "Symfony\\Component\\Cache\\Marshaller\\DefaultMarshaller", "type": "service", "id": "cache.default_marshaller" }EDIT: It might break BC because methods' signature has been changed (Added an argument with a default value)