[Serializer] add a context to allow invalid values in BackedEnumNormalizer #48821
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
serializer/allow-invalid-enum-value
branch
2 times, most recently
from
d8e613f
to
cc6dfd1
Compare
mtarld
suggested changes
Jan 20, 2023
src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
serializer/allow-invalid-enum-value
branch
5 times, most recently
from
89b9d3c
to
8130e24
Compare
dunglas
requested changes
Jan 24, 2023
src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
serializer/allow-invalid-enum-value
branch
from
8130e24
to
36cd0a2
Compare
dunglas
approved these changes
Jan 24, 2023
src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php
Outdated
Show resolved
Hide resolved
mtarld
approved these changes
Jan 24, 2023
nikophil
force-pushed
the
serializer/allow-invalid-enum-value
branch
2 times, most recently
from
5302a07
to
b431dcc
Compare
mtarld
reviewed
Jan 26, 2023
src/Symfony/Component/Serializer/Context/Normalizer/BackedEnumNormalizerContextBuilder.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
serializer/allow-invalid-enum-value
branch
from
b431dcc
to
6bc64f5
Compare
nicolas-grekas
reviewed
Jan 26, 2023
...ony/Component/Serializer/Tests/Context/Normalizer/BackedEnumNormalizerContextBuilderTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Jan 26, 2023
nikophil
force-pushed
the
serializer/allow-invalid-enum-value
branch
from
6bc64f5
to
5dab5c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
sometimes it is needed to allow deserialization of an enum to end up in a
nullvalue, this PR allows this behavior by passing a context