[Messenger] Respect isRetryable decision of the retry strategy for re-delivery
#49063
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deciding if failed message should be re-delivered
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Documentation for retry strategy for the Messenger component declares that message will not be retried to be re-delivered more than the value of
max_retriesconfiguration for the retry strategy.However, after merging #36557 actual implementation gives priority to the existence of the
RecoverableExceptionInterface, effectively opening a way for a message to be re-delivered indefinitely.Additionally, in the case of using
multiplierwith a value of more than 1 this unlimited re-delivery causes unlimited growth of thedelayvalue for theDelayStamp. Its type is defined asint, so on 32-bit platforms after some timedelayvalue may exceedPHP_INT_MAXwhich will lead to theTypeError.The proposed change enforces respect for the
max_retriessetting value for the decision of re-delivery.