Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43908: Make heap types converted during 3.10 alpha immutable #26351

Merged
merged 20 commits into from Jun 17, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 25, 2021

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 25, 2021

I'll add tests in separate PRs.

@pablogsal
Copy link
Member

pablogsal commented May 25, 2021

@vstinner could you take a look?

@rhettinger rhettinger removed their request for review May 31, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 10, 2021

@vstinner Do you want me to break this up in multiple PR's? The number of files changed is high, but the actual diff is pretty short (+61 −38).

@pablogsal
Copy link
Member

pablogsal commented Jun 15, 2021

@vstinner Can you review this by Thursday, as this is a release blocker for beta 3?

@pablogsal pablogsal merged commit 00710e6 into python:main Jun 17, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 17, 2021

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2021
…honGH-26351)

* Make functools types immutable

* Multibyte codec types are now immutable

* pyexpat.xmlparser is now immutable

* array.arrayiterator is now immutable

* _thread types are now immutable

* _csv types are now immutable

* _queue.SimpleQueue is now immutable

* mmap.mmap is now immutable

* unicodedata.UCD is now immutable

* sqlite3 types are now immutable

* _lsprof.Profiler is now immutable

* _overlapped.Overlapped is now immutable

* _operator types are now immutable

* winapi__overlapped.Overlapped is now immutable

* _lzma types are now immutable

* _bz2 types are now immutable

* _dbm.dbm and _gdbm.gdbm are now immutable
(cherry picked from commit 00710e6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Jun 17, 2021

GH-26766 is a backport of this pull request to the 3.10 branch.

@erlend-aasland erlend-aasland deleted the bpo-43908/3.10-types branch Jun 17, 2021
pablogsal pushed a commit that referenced this pull request Jun 17, 2021
…26351) (GH-26766)

* Make functools types immutable

* Multibyte codec types are now immutable

* pyexpat.xmlparser is now immutable

* array.arrayiterator is now immutable

* _thread types are now immutable

* _csv types are now immutable

* _queue.SimpleQueue is now immutable

* mmap.mmap is now immutable

* unicodedata.UCD is now immutable

* sqlite3 types are now immutable

* _lsprof.Profiler is now immutable

* _overlapped.Overlapped is now immutable

* _operator types are now immutable

* winapi__overlapped.Overlapped is now immutable

* _lzma types are now immutable

* _bz2 types are now immutable

* _dbm.dbm and _gdbm.gdbm are now immutable
(cherry picked from commit 00710e6)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
…honGH-26351)

* Make functools types immutable

* Multibyte codec types are now immutable

* pyexpat.xmlparser is now immutable

* array.arrayiterator is now immutable

* _thread types are now immutable

* _csv types are now immutable

* _queue.SimpleQueue is now immutable

* mmap.mmap is now immutable

* unicodedata.UCD is now immutable

* sqlite3 types are now immutable

* _lsprof.Profiler is now immutable

* _overlapped.Overlapped is now immutable

* _operator types are now immutable

* winapi__overlapped.Overlapped is now immutable

* _lzma types are now immutable

* _bz2 types are now immutable

* _dbm.dbm and _gdbm.gdbm are now immutable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants