Make onAuthenticationSuccess Response optional #48288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3 for features / 4.4, 5.4, 6.0, 6.1, or 6.2 for bug fixes ". Cheers! Carsonbot |
fabpot
reviewed
Dec 9, 2022
| @@ -31,5 +31,5 @@ interface AuthenticationSuccessHandlerInterface | |||
| * is called by authentication listeners inheriting from | |||
| * AbstractAuthenticationListener. | |||
| */ | |||
| public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response; | |||
| public function onAuthenticationSuccess(Request $request, TokenInterface $token): ?Response; | |||
There was a problem hiding this comment.
That would be a BC break, so not something we can do.
There was a problem hiding this comment.
Widening the return type to allow null is fine compiler-wise: https://3v4l.org/rDAPN, so only callers could be impacted. As this method is called by authenticators, I would be ok to do this on 6.3 (with changelog entry).
chalasr
added
Status: Needs Work
and removed
Bug
Status: Needs Review
Deprecation
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Most authenticators currently use onAuthenticationSuccess with an optional Response. That's mainly due to usecases whereby we want to redirect specific users etc.