Skip to content

Commits

Permalink
6.4
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?

Commits on Jun 2, 2023

  1. Merge branch '6.3' into 6.4

    * 6.3:
      [PhpUnitBridge] Fix requiring bootstrap.php
      [Messenger] Prevent `StopWorkerOnSignalsListener::$signals` to be assigned to null in case `SIGTERM` constant doesn't exist
    nicolas-grekas committed Jun 2, 2023
  2. bug #50532 [Messenger] Prevent `StopWorkerOnSignalsListener::$signals…

    …` to be assigned to null in case `SIGTERM` constant doesn't exist (alexandre-daubois)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [Messenger] Prevent `StopWorkerOnSignalsListener::$signals` to be assigned to null in case `SIGTERM` constant doesn't exist
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #50529
    | License       | MIT
    | Doc PR        | _NA_
    
    Prevents the non-nullable property to be assigned to null 🙂
    
    Commits
    -------
    
    538a9ab [Messenger] Prevent `StopWorkerOnSignalsListener::$signals` to be assigned to null in case `SIGTERM` constant doesn't exist
    fabpot committed Jun 2, 2023

Commits on Jun 1, 2023

  1. [Messenger] Prevent StopWorkerOnSignalsListener::$signals to be ass…

    …igned to null in case `SIGTERM` constant doesn't exist
    alexandre-daubois committed Jun 1, 2023
  2. Merge branch '6.3' into 6.4

    * 6.3:
      [PhpUnitBridge] Fix classifying doctrine/deprecations as direct/indirect
      [PhpUnitBridge] Add missing line in changelog
      [Serializer] Fix ignoring objects that only implement DenormalizableInterface
    nicolas-grekas committed Jun 1, 2023
  3. bug #50525 [PhpUnitBridge] Fix classifying doctrine/deprecations as d…

    …irect/indirect (nicolas-grekas)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] Fix classifying doctrine/deprecations as direct/indirect
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    d2b5209 [PhpUnitBridge] Fix classifying doctrine/deprecations as direct/indirect
    nicolas-grekas committed Jun 1, 2023
  4. bug #50521 [Serializer] Fix ignoring objects that only implement Deno…

    …rmalizableInterface (spideyfusion)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [Serializer] Fix ignoring objects that only implement DenormalizableInterface
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
    | License       | MIT
    | Doc PR        | N/A <!-- required for new features -->
    
    When the #49291 optimization got introduced, the `DenormalizableInterface` type was left out of the `CustomNormalizer` normalizer's `getSupportedTypes` implementation.
    
    This prevents us for example, implementing custom deserialization logic for API objects where we can't describe all deserialization rules via attributes.
    
    <!--
    Replace this notice by a short README for your feature/bugfix.
    This will help reviewers and should be a good start for the documentation.
    
    Additionally (see https://symfony.com/releases):
     - Always add tests and ensure they pass.
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the latest branch.
     - For new features, provide some code snippets to help understand usage.
     - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
     - Never break backward compatibility (see https://symfony.com/bc).
    -->
    
    Commits
    -------
    
    a0a3ce1 [Serializer] Fix ignoring objects that only implement DenormalizableInterface
    nicolas-grekas committed Jun 1, 2023
  5. Merge branch '6.3' into 6.4

    * 6.3:
      [Cache] Fix tests
      [Mailer] [MailPace] Fix undefined array key in errors response
      [DependencyInjection] Allow casting env var processors to cast null
      [VarDumper] Add named arguments coverage of VarDumper's function
      [SecurityBundle] Use LogicException instead of Definition::addError()
      [PhpUnitBridge] Disable deduplication of Doctrine deprecations
      [Cache] Fix DBAL deprecations
      [Messenger] Add deprecation message for the "messenger.listener.stop_worker_on_sigterm_signal_listener" service
      Fix broken symlink tests Windows PHP 7.4+
      [SecurityBundle] Fix error message when using OIDC and web-token/jwt-core is not installed
      [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
      add @throws to getPayload
      [FrameworkBundle] ease migration to symfony 6.3
      [VarDumper] Use documentElement instead of body for JS flag
      Bump Symfony version to 6.3.1
      Update VERSION for 6.3.0
      Update CHANGELOG for 6.3.0
      [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
    nicolas-grekas committed Jun 1, 2023
  6. Merge branch '6.2' into 6.3

    * 6.2:
      [Cache] Fix tests
      [Mailer] [MailPace] Fix undefined array key in errors response
      [DependencyInjection] Allow casting env var processors to cast null
      [Cache] Fix DBAL deprecations
      Fix broken symlink tests Windows PHP 7.4+
      [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
      [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
    nicolas-grekas committed Jun 1, 2023
  7. Merge branch '5.4' into 6.2

    * 5.4:
      [Cache] Fix tests
      [DependencyInjection] Allow casting env var processors to cast null
      [Cache] Fix DBAL deprecations
      Fix broken symlink tests Windows PHP 7.4+
      [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
    nicolas-grekas committed Jun 1, 2023
  8. [Cache] Fix tests

    nicolas-grekas committed Jun 1, 2023
  9. bug #50517 [DependencyInjection] Fix casting scalar env vars from nul…

    …l (fancyweb)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Fix casting scalar env vars from null
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | -
    | Tickets       | #50415
    | License       | MIT
    | Doc PR        | -
    
    Using a casting env var processor on `null` returns `null` (it doesn't cast) which is not what one could expect and not what is documented. We could allow it.
    
    Commits
    -------
    
    c4b16e5 [DependencyInjection] Allow casting env var processors to cast null
    nicolas-grekas committed Jun 1, 2023
  10. bug #50515 [Mailer] [MailPace] Fix undefined array key in errors resp…

    …onse (Florian Heller)
    
    This PR was squashed before being merged into the 6.2 branch.
    
    Discussion
    ----------
    
    [Mailer] [MailPace] Fix undefined array key in errors response
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.2
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | none
    | License       | MIT
    | Doc PR        | -
    
    This PR fixes a bug which occurs when MailPace returns an `errors` response instead of `error` (see https://docs.mailpace.com/reference/responses/ for possible responses).
    
    Without this fix, the `errors` response leads to the following exception: `ErrorException: Undefined array key "error"`
    
    I added two tests to verify that:
    - responses with multiple errors are returned as readable error message
    - empty responses generate a readable error message
    
    To fix the bug I added a check for the existence of the `error`/`errors` key in the `$result` variable and a fallback just in case that both are not present.
    
    Commits
    -------
    
    38a7ee5 [Mailer] [MailPace] Fix undefined array key in errors response
    nicolas-grekas committed Jun 1, 2023
  11. minor #50519 [SecurityBundle] Use LogicException instead of Definitio…

    …n::addError() (nicolas-grekas)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
     [SecurityBundle] Use LogicException instead of Definition::addError()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Let's keep things simple :)
    
    Commits
    -------
    
    5ffa61c [SecurityBundle] Use LogicException instead of Definition::addError()
    nicolas-grekas committed Jun 1, 2023
  12. bug #50514 [PhpUnitBridge] Disable deduplication of Doctrine deprecat…

    …ions (nicolas-grekas)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] Disable deduplication of Doctrine deprecations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Deprecation reports are not accurate with deduplication enabled.
    
    Commits
    -------
    
    03392b6 [PhpUnitBridge] Disable deduplication of Doctrine deprecations
    nicolas-grekas committed Jun 1, 2023
  13. minor #50512 [VarDumper] Add named arguments coverage of VarDumper's …

    …function (alexandre-daubois)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [VarDumper] Add named arguments coverage of VarDumper's function
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | _NA_
    | License       | MIT
    | Doc PR        | _NA_
    
    Taking advantage of `.phpt` files added in 6.3 to add coverage on named arguments support of `dump` and `dd`.
    
    Commits
    -------
    
    2a29674 [VarDumper] Add named arguments coverage of VarDumper's function
    nicolas-grekas committed Jun 1, 2023

Commits on May 31, 2023

  1. bug #50508 [Messenger] Add deprecation message for the `messenger.lis…

    …tener.stop_worker_on_sigterm_signal_listener` service (alexandre-daubois)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [Messenger] Add deprecation message for the `messenger.listener.stop_worker_on_sigterm_signal_listener` service
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix ##50499
    | License       | MIT
    | Doc PR        | _NA_
    
    Commits
    -------
    
    02909a2 [Messenger] Add deprecation message for the "messenger.listener.stop_worker_on_sigterm_signal_listener" service
    nicolas-grekas committed May 31, 2023
  2. bug #50507 [Cache] Fix DBAL deprecations (MatTheCat)

    This PR was squashed before being merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Cache] Fix DBAL deprecations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Part of #50481
    | License       | MIT
    | Doc PR        | N/A
    
    Unfortunately calling `Table::getColumns` will still produce deprecations 🤔
    
    Commits
    -------
    
    bec5302 [Cache] Fix DBAL deprecations
    nicolas-grekas committed May 31, 2023
  3. [Cache] Fix DBAL deprecations

    MatTheCat authored and nicolas-grekas committed May 31, 2023
  4. minor #50506 [Filesystem] Fix broken symlink tests Windows PHP 7.4+ (…

    …ausi)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Filesystem] Fix broken symlink tests Windows PHP 7.4+
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Followup to #50437
    | License       | MIT
    | Doc PR        | -
    
    The test currently fail on windows with PHP >= 7.4
    
    ```
    1) Symfony\Component\Filesystem\Tests\FilesystemTest::testReadBrokenLink
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'C:\…\Temp\1685536465.4767.1091468882/file'
    +'C:\…\Temp\1685536465.4767.1091468882\file'
    
    C:\…\src\Symfony\Component\Filesystem\Tests\FilesystemTest.php:1105
    ```
    
    Commits
    -------
    
    d98a011 Fix broken symlink tests Windows PHP 7.4+
    nicolas-grekas committed May 31, 2023
  5. [Messenger] Add deprecation message for the "messenger.listener.stop_…

    …worker_on_sigterm_signal_listener" service
    alexandre-daubois committed May 31, 2023
  6. minor #50492 [HttpFoundation] add @throws to getPayload (wiseguy1394)

    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] add `@throws` to getPayload
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #50490
    | License       | MIT
    
    Fixes #50490
    
    Commits
    -------
    
    9ae8b6c add `@throws` to getPayload
    nicolas-grekas committed May 31, 2023
  7. bug #50501 [Serializer] Fix discriminator map not working with `Abstr…

    …actNormalizer::OBJECT_TO_POPULATE` (HypeMC)
    
    This PR was merged into the 5.4 branch.
    
    Discussion
    ----------
    
    [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 5.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Followup / backport of #50480 since it should've originally targeted 5.4.
    
    The test is the same as in the previous PR, when merging upstream the changes in `instantiateObject()` should be discarded.
    
    Commits
    -------
    
    ce08608 [Serializer] Fix discriminator map not working with `AbstractNormalizer::OBJECT_TO_POPULATE`
    nicolas-grekas committed May 31, 2023
  8. bug #50503 [SecurityBundle] Fix error message when using OIDC and web…

    …-token/jwt-core is not installed (nicolas-grekas)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] Fix error message when using OIDC and web-token/jwt-core is not installed
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #50491
    | License       | MIT
    | Doc PR        | -
    
    Before:
    > Service "security.access_token_handler.oidc.signature.ES256": Cannot replace arguments for class "Jose\Component\Signature\Algorithm\ES256" if none have been configured yet.
    
    After:
    > You cannot use the "oidc" token handler since "web-token/jwt-core" is not installed. Try running "composer require web-token/jwt-core".
    
    /cc `@vincentchalamon`
    
    Commits
    -------
    
    c106c5f [SecurityBundle] Fix error message when using OIDC and web-token/jwt-core is not installed
    nicolas-grekas committed May 31, 2023
  9. bug #50498 [FrameworkBundle] ease migration to symfony 6.3 (lyrixx)

    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] ease migration to symfony 6.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | kind of
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | #50504
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    06ab7ec [FrameworkBundle] ease migration to symfony 6.3
    nicolas-grekas committed May 31, 2023
Older