[DependencyInjection] Escape % from parameter-like default values
#50478
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
ticket_50469
branch
from
8d2fff0
to
edf11bc
Compare
nicolas-grekas
approved these changes
May 30, 2023
nicolas-grekas
force-pushed
the
ticket_50469
branch
from
edf11bc
to
bb4eeb0
Compare
|
Thank you @MatTheCat. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When string default values are autowired, they shouldn’t reference parameters.
This PR tries to address the issue by escaping them in the
AutowirePass.