-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-61456: Add Thai language codec aliases #15079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding aliases for Thai language support. The current code page is an implementation of the windows code page. This will alias '874', 'ms874', and 'windows_874' to cp874, adding Thai language support for those users.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
CLA Submitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are failed. Please review it . And maybe a NEWs should be necessary?
Got all checks to pass. Ready for review. |
@eamanu Bumping this because it's been a while. |
bumping again, and adding some details here. To quote myself from the bug ticket:
|
@malemburg please review or tap another. |
I'll also throw a bump in here - the email's
|
Added new line for lint.
@malemburg @ezio-melotti @csabella I'm looking forward to squashing this years long bug. In my work writing python email parsers, we definitely saw this from Thai senders using Microsoft email clients. Thanks! |
Adding aliases for Thai language support. The current code page is an implementation of the windows code page. This will alias '874', 'ms874', and 'windows_874' to cp874, adding Thai language support for those users. Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Adding aliases for Thai language support. The current code page is an implementation of the windows code page.
This will alias '874', 'ms874', and 'windows_874' to cp874, adding Thai language support for those users.
https://bugs.python.org/issue17254