[Notifier] Update Slack Bridge README.md #50533
Conversation
* Adding section to activate Slack transport into notifier.yaml * adding typehint for `$chatter` as i needed to inject its dependency into my service and i was looking for the service class.
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.3 for bug fixes". Cheers! Carsonbot |
| @@ -26,6 +26,16 @@ SLACK_DSN=slack://xoxb-......@default?channel=#my-channel-name | |||
| SLACK_DSN=slack://xoxb-......@default?channel=fabien | |||
| ``` | |||
|
|
|||
| Activate Slack transports into config/packages/notifier.yaml | |||
| -------------------------------- | |||
There was a problem hiding this comment.
The number of dashes should be the same as the line above :)
|
Closing in favor of symfony/recipes#1217, thanks for the idea :) |
Update README as it looks like unclear for me:
$chatter: when using code sample, i needed to inject ChatterInterface dependency to make it works and i was unsure which Service was involved there.And maybe it's missing: add a link to slack documentation on how to create an API token ?
https://api.slack.com/authentication/basics