Support "bpo-" in Misc/NEWS #1

brettcannon · 2017-02-10T22:41:57Z

No description provided.

Carreau · 2017-02-10T22:44:39Z

Doc/tools/extensions/pyspecific.py

@@ -253,7 +253,7 @@ def run(self):
            text = 'The NEWS file is not available.'
            node = nodes.strong(text, text)
            return [node]
-        content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
+        content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__',


\b ? I think you overwrote the \1 :-)

That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.

Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.

Ah, you're right. Now fixed.

Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.

zware · 2017-02-10T22:59:44Z

Doc/tools/extensions/pyspecific.py

@@ -34,7 +34,7 @@


 ISSUE_URI = 'https://bugs.python.org/issue%s'
-SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s'
+SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s'


Shouldn't it be master rather than 3.6 on this branch?

My patch for another issue will address this, I think 🤔

http://bugs.python.org/file45904/issue28941.patch

I went ahead and updated here since I'm already changing it.

zware · 2017-02-10T23:01:03Z

Doc/tools/extensions/pyspecific.py

@@ -253,7 +253,7 @@ def run(self):
            text = 'The NEWS file is not available.'
            node = nodes.strong(text, text)
            return [node]
-        content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
+        content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__',


I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/

(cherry picked from commit 79ab8be)

Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py

Change the url to 2.7 (cherry picked from commit 79ab8be)

…#44) * Support "bpo-" in Misc/NEWS (#1) Change the url to 2.7 (cherry picked from commit 79ab8be) * pyspecific.py: remove space after` bpo-`

Change the url to 3.5 (cherry picked from commit 79ab8be) Contributed by Brett Cannon

* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma

python#7287 (comment)

* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com> Rebased for Python 2.7 by Michał Górny <mgorny@gentoo.org>

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com> (cherry picked from commit db95802) Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>

mariatta-bot · 2022-01-19T18:48:33Z

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

mariatta-bot · 2022-01-19T18:49:45Z

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

Mariatta · 2022-01-19T18:50:43Z

Sorry, please ignore my bot. Experimenting ...

Fix test_gdb.test_pycfunction() for Python built with clang -Og. Tolerate inlined functions in the gdb traceback. When _testcapimodule.c is built by clang -Og, _null_to_none() is inlined in meth_varargs() and so gdb returns _null_to_none() as the frame #1. If it's not inlined, meth_varargs() is the frame #1.

Fix an uninitialized bool in exception print context. `struct exception_print_context.need_close` was uninitialized. Found by oss-fuzz in a test case running under the undefined behavior sanitizer. https://oss-fuzz.com/testcase-detail/6217746058182656 ``` Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool' #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28 #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19 #2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13 #3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9 ``` Pretty obvious what the ommission was upon code inspection.

pypa/pip#11188 (error python#1) https://www.notion.so/ff917cee6e4e477ca8090c4aef34fbd1

Create a webservice that receives the GitHub Webhook events.

Support "bpo-" in Misc/NEWS

1900740

the-knights-who-say-ni added the CLA signed label Feb 10, 2017

Carreau reviewed Feb 10, 2017

View changes

Fix up the match and substitution regexes

5401164

Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.

Carreau approved these changes Feb 10, 2017

View changes

zware reviewed Feb 10, 2017

View changes

Address reviewer comments

02a87ce

zware approved these changes Feb 10, 2017

View changes

zware merged commit 79ab8be into master Feb 10, 2017

brettcannon deleted the bpo-news-support branch Feb 10, 2017

Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017

Support "bpo-" in Misc/NEWS (#1)

98cb83e

(cherry picked from commit 79ab8be)

Mariatta mentioned this pull request Feb 12, 2017

[backport to 3.6] Bpo news support 3.6 #42

Merged

Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017

Support "bpo-" in Misc/NEWS (#1)

73e2903

Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py

Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017

Support "bpo-" in Misc/NEWS (#1)

63b8f25

Change the url to 2.7 (cherry picked from commit 79ab8be)

Mariatta added a commit that referenced this pull request Feb 13, 2017

Support "bpo-" in Misc/NEWS (#1) (#43)

af456b2

Change the url to 3.5 (cherry picked from commit 79ab8be) Contributed by Brett Cannon

csabella mentioned this pull request Dec 22, 2017

bpo-20285: Improve help docs for object #4759

Merged

bapt mentioned this pull request Jan 18, 2018

bpo-32593: distutils UnixCCompiler: remove FreeBSD special case #5233

Closed

native-api pushed a commit to native-api/cpython that referenced this pull request Jun 5, 2018

Merge pull request python#1 from native-api/roseman_1

9a5b0e8

python#7287 (comment)

Clucier17 reviewed Jul 28, 2018

View changes

aixtools mentioned this pull request Oct 26, 2018

bpo-1154351: Add get_current_dir_name() to os module #10117

Closed

brianquinlan mentioned this pull request May 8, 2019

bpo-31783: Fix a race condition creating workers during shutdown #13171

Merged

tim-one mentioned this pull request May 29, 2019

bpo-37029: keep usable_arenas in sorted order without searching #13612

Merged

ElizabethU mentioned this pull request Jul 20, 2019

bpo-37555: Update _CallList.__contains__ to respect ANY #14700

Merged

btharper mentioned this pull request Oct 6, 2019

bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" #16598

Merged

ezio-melotti mentioned this pull request Dec 5, 2020

Issue (re)numbering psf/gh-migration#1

Closed

miss-islington mentioned this pull request Dec 14, 2020

[3.6] bpo-40791: Make compare_digest more constant-time. (GH-23438) #23767

Merged

ericsnowcurrently mentioned this pull request Sep 10, 2021

bpo-45020: Freeze the modules imported during startup. #28107

Closed

vstinner mentioned this pull request Feb 1, 2022

bpo-46600: Fix test_gdb.test_pycfunction() for clang -Og #31058

Merged

markshannon mentioned this pull request May 9, 2022

bpo-46841: Don't jump during throw() #31968

Closed

diasjoaocarlos mentioned this pull request May 15, 2022

Python 3.7.13 - Segmentation fault on import #92825

Closed

ilCatania mentioned this pull request May 25, 2022

Multiple TimedRotatingFileHandler with similar names but different backup counts do not work #93205

Open

larryhastings mentioned this pull request Jun 7, 2022

The Great Argument Clinic Conversion Derby Meta-Issue #64386

Closed

umdstu mentioned this pull request Jun 22, 2022

*** Error in `python': double free or corruption (out): 0x00007ff5254d50d0 *** #77266

Open

grv87 added a commit to grv87/cpython that referenced this pull request Jul 8, 2022

fix: use correct separators in sysconfig

649c3e1

pypa/pip#11188 (error python#1) https://www.notion.so/ff917cee6e4e477ca8090c4aef34fbd1

jdhedden mentioned this pull request Jul 13, 2022

CentOS 7 GCC 4.8.5 miscompiles optimized build: <built-in function compile> returned NULL without setting an exception #94825

Open

itachaaa mentioned this pull request Aug 22, 2022

Python 3.10 hang at exit in drop_gil() (due to resource warning at exit?) #91414

Open

mdboom mentioned this pull request Aug 25, 2022

Assert and incorrect error message when loading source file containing invalid UTF-8 #96268

Closed

python deleted a comment from rpsene Sep 21, 2022

mdboom mentioned this pull request Nov 22, 2022

Segmentation fault running ensurepip during an --enable-pystats build #99701

Closed

ziegenbalg mentioned this pull request Nov 30, 2022

double free in io.TextIOWrapper #72573

Closed

jaraco pushed a commit that referenced this pull request Dec 2, 2022

Initial commit of Python cherry-picker bot (#1)

e728050

Create a webservice that receives the GitHub Webhook events.

Support "bpo-" in Misc/NEWS #1

Support "bpo-" in Misc/NEWS #1

brettcannon commented Feb 10, 2017

Carreau Feb 10, 2017

brettcannon Feb 10, 2017

Carreau Feb 10, 2017

brettcannon Feb 10, 2017

zware Feb 10, 2017

Mariatta Feb 10, 2017

brettcannon Feb 10, 2017

Mariatta Feb 10, 2017

zware Feb 10, 2017

brettcannon Feb 10, 2017

mariatta-bot commented Jan 19, 2022

mariatta-bot commented Jan 19, 2022

Mariatta commented Jan 19, 2022

Support "bpo-" in Misc/NEWS #1

Support "bpo-" in Misc/NEWS #1

Conversation

brettcannon commented Feb 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mariatta-bot commented Jan 19, 2022

mariatta-bot commented Jan 19, 2022

Mariatta commented Jan 19, 2022