Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-105375: Harden error handling in _testcapi/heaptype.c #105608

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023

Bail on first error in heapctypesubclasswithfinalizer_finalize()

Bail on first error in heapctypesubclasswithfinalizer_finalize()
@erlend-aasland
Copy link
Contributor Author

I consider this a non-controversial and straight-forward change, so I'll land as soon as the CI is green.

@erlend-aasland erlend-aasland changed the title gh-105375: Fix error handling in testcapi heaptype test gh-105375: Harden error handling in _testcapi/heaptype.c Jun 9, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) June 9, 2023 21:26
@erlend-aasland erlend-aasland merged commit d636d7d into python:main Jun 9, 2023
22 checks passed
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
…honGH-105608)

Bail on first error in heapctypesubclasswithfinalizer_finalize()
(cherry picked from commit d636d7dfe714e7168b342c7ea5f9f9d3b3569ed0)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105615 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 9, 2023
@erlend-aasland erlend-aasland deleted the improve-testcapi-error-handling branch June 9, 2023 21:54
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
…-105608) (#105615)

Bail on first error in heapctypesubclasswithfinalizer_finalize()
(cherry picked from commit d636d7d)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants