bpo-7938: the makesetup script now respects macro define arguments of… #4338
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the form '-Dname=definition' Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
I have signed the CLA. |
|
I wonder if we can simplify this by assuming the make variables are of the form |
|
Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
… the form '-Dname=definition'
Previously adding a macro define argument in the Modules/Setup file such as '-Dname=value' was recognised by the makesetup script as a Make variable definition due to the '=' character. This change uses sed to find lines with only one token to the left of the first '=' which it treats as a Make variable definition. Lines not matching this criteria are matched as module definitions. Moreover, this change respects Make variable definitions with '=', ':=', '::=', '+=' and '?=' syntax.
https://bugs.python.org/issue7938