New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99108: Import SHA2-384/512 from HACL* #101707
Conversation
(I pulled the wrong revision of HACL*, hence the build breakage -- I'll fix this shortly.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build system changes look good to me.
|
|
|
|
Thanks for merging, @gpshead. It looks like this broke the wasm build because there are now duplicate symbols. If I had to guess, I would say that the use-case where two C files in Modules/ depend on the same C file did not show up before in the build. Would it be enough to remove one of the two references to Hacl_Streaming_SHA2.c in Modules/Setup.stdlib.in? |
Followup on #99108, and almost identical to #99109