typing.NewType docs: the future performance improvements are now in the past
#105354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
skip issue
topic-typing
needs backport to 3.11
AlexWaygood
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
bedevere-bot
added
awaiting core review
docs
|
My benchmarks for
So this seems right. |
|
Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2023
1�7 the past (pythonGH-105354) (cherry picked from commit 5f65ff0) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
GH-105414 is a backport of this pull request to the 3.12 branch. |
|
GH-105415 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2023
1�7 the past (pythonGH-105354) (cherry picked from commit 5f65ff0) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Yeah, I checked before filing the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, as Serhiy suggested, we could just delete the bit in the existing
.. versionchangednote that mentions the performance degradation in Python 3.10.📚 Documentation preview 📚: https://cpython-previews--105354.org.readthedocs.build/