-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-105373: Remove PyArg_Parse() deprecation #105394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@birkenfeld: Hi, do you recall why you considered to deprecated PyArg_Parse() when you documented the |
It makes sense because |
PyArg_Parse() is used with I believe that it is a useful function and should remain. |
Argument Clinic generates PyArg_Parse() calls for some function signatures. There are around 69 calls to PyArg_Parse() in the CPython code base, included 15 genereated by Argument Clinic. If we really want to get ride of it, we should be good citizen and start by cleaning our own code base. But here I agree with @serhiy-storchaka, this function is fine and should be kept. If there are use cases where others functions are more appropriated, maybe the doc should be enhanced? @methane: What do you think? |
I had read only the doc. If there are enough use case for |
There is no plan to deprecate PyArg_Parse(). The deprecation was added as a comment in the C API documentation in 2007 by commit 85eb8c1.
a4e9a4d
to
ecee586
Compare
I rewrote PyArg_Parse() documentation. Would you mind to review the updated PR? |
Just to leave my requested feedback, I don't remember anything about this specific function :) |
There is no plan to deprecate PyArg_Parse().
The deprecation was added as a comment in the C API documentation in 2007 by commit 85eb8c1.
📚 Documentation preview 📚: https://cpython-previews--105394.org.readthedocs.build/