fix: when scheduling next update in the presence service _presentChannels.length is always undefined
#22053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnels.length` is always undefined The else if is then never triggered.
| @@ -606,7 +606,7 @@ export default class PresenceService extends Service { | |||
| ); | |||
| } else if ( | |||
| !this._nextUpdateTimer && | |||
| this._presentChannels.length > 0 && | |||
| this._presentChannels.size > 0 && | |||
There was a problem hiding this comment.
this._presentChannels is a JS Set, so size should always return a value. What makes you say it's 'always undefined'? 🤔
There was a problem hiding this comment.
Yes that's what I said. .length is always undefined .size works. ( right now in the code it's .length ) I was trying to implement same mechanism and I am using typescript so it complained and I tried it in the console:
There was a problem hiding this comment.
Aha I see, I read the diff backwards. Thanks for the fix @Mubramaj 🙌
davidtaylorhq
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The else if is then never triggered.
I would like to create a test but the
else ifis also testing!isTesting()so my test wouldn't be meaningful