DEV: Deselect all and reset to defaults btns to edit categories modal #22143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
deselect_all_button
branch
2 times, most recently
from
c6209c5 to
b4f343a
Compare
RecordingsReset to defaults
Deselect all
|
|
@lis2 or @OsamaSayegh Can you review this for me? Thank you 👍 |
tgxworld
force-pushed
the
deselect_all_button
branch
5 times, most recently
from
ddff066 to
671bb8d
Compare
What does this change do? This change adds the deselect all and reset to defaults buttons to the edit navigation menu categories modal. The deselect all button when click deselects all the selected categories in the modal. If the user saves with no categories selected, the user's categories section in the navigation menu will be set to the site's top categories. The reset to defaults button is only shown when the `default_navigation_menu_categories` site setting has been configured. When clicked, the user's categories section in the navigation menu is automatically set to the categories defined by the `default_navigation_menu_categories` site setting.
tgxworld
force-pushed
the
deselect_all_button
branch
from
671bb8d to
ad8b5ff
Compare
lis2
reviewed
Jun 19, 2023
| @disabled={{this.saving}} | ||
| @action={{this.save}} | ||
| /> | ||
| {{#if (gt this.siteSettings.default_navigation_menu_categories.length 0)}} |
There was a problem hiding this comment.
Just idea, shall we display reset to default button only if current selection is different than default?
There was a problem hiding this comment.
I thought about this but I find buttons that disappear and reappear very confusing since it causes something to flash on the screen.
lis2
approved these changes
Jun 20, 2023
|
Thank you for reviewing @lis2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change do?
This change adds the deselect all and reset to defaults buttons to the
edit navigation menu categories modal. The deselect all button when
click deselects all the selected categories in the modal. If the user
saves with no categories selected, the user's categories section in the
navigation menu will be set to the site's top categories.
The reset to defaults button is only shown when the
default_navigation_menu_categoriessite setting has been configured.When clicked, the user's categories section in the navigation menu is
automatically set to the categories defined by the
default_navigation_menu_categoriessite setting.