DEV: Remove deprecated 'desc' parameter from group members endpoint #22147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
force-pushed
the
dev/remove-deprecated-group-members-parameter
branch
from
477c25b to
eecf76c
Compare
tgxworld
approved these changes
Jun 16, 2023
|
Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This parameter was deprecated three years ago, and was due to be dropped in 2.9. I searched our logs, and there were 3 entries. They all had some nonsense value, e.g. a link, an HTML fragment, etc. so might be bots. Either way it should be safe to remove this now. The maximum impact is the ordering will fall back to ASC.