[Routing] Prevent duplicated methods and schemes in Route #50107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you prefer, we can fix this in the command only? |
fancyweb
force-pushed
the
routing/fix-minor-route-arr-unique
branch
from
bedc045 to
401f703
Compare
nicolas-grekas
approved these changes
May 25, 2023
nicolas-grekas
approved these changes
Jun 28, 2023
src/Symfony/Component/Routing/Tests/Fixtures/AnnotationFixtures/GlobalDefaultsClass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Routing/Tests/Fixtures/AnnotationFixtures/GlobalDefaultsClass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/GlobalDefaultsClass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/GlobalDefaultsClass.php
Outdated
Show resolved
Hide resolved
fancyweb
force-pushed
the
routing/fix-minor-route-arr-unique
branch
from
401f703 to
5923d07
Compare
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods and schemes can be "duplicated" if declared globally on the controller and also on the method. It impacts the
debug:routercommand displayingGET|GETfor the methods column for example.