Skip to content

[MRG] DOC add __sklearn_is_fitted__ example #26618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 17, 2023
Merged

[MRG] DOC add __sklearn_is_fitted__ example #26618

merged 27 commits into from
Jul 17, 2023

Conversation

greyisbetter
Copy link
Contributor

@greyisbetter greyisbetter commented Jun 19, 2023 •
edited
Loading

Reference Issues/PRs

Fixes #26518

What does this implement/fix? Explain your changes.

cc @adrinjalali

@greyisbetter greyisbetter changed the title [MRG] added __sklearn_is_fitted__ example and mentioned in Developing estimators [MRG] DOC added __sklearn_is_fitted__ example and mentioned in Developing estimators Jun 20, 2023
adrinjalali
adrinjalali reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @greyisbetter

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 14b4b0f. Link to the linter CI: here

@greyisbetter
Copy link
Contributor Author

Thank you for reviewing @adrinjalali. I updated the code as suggestions.

@greyisbetter greyisbetter changed the title [MRG] DOC added __sklearn_is_fitted__ example and mentioned in Developing estimators [MRG] DOC added __sklearn_is_fitted__ example Jun 22, 2023
adrinjalali
adrinjalali reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@adrinjalali adrinjalali changed the title [MRG] DOC added __sklearn_is_fitted__ example [MRG] DOC add __sklearn_is_fitted__ example Jun 22, 2023
@adrinjalali adrinjalali added the Waiting for Second Reviewer First reviewer is done, need a second one! label Jun 22, 2023
@adrinjalali
Copy link
Member

@betatim maybe?

lucyleeow
lucyleeow reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick flyby review, thanks!

@greyisbetter
Copy link
Contributor Author

@OmarManzoor, I kindly request your feedback on this matter as well.

@adrinjalali
Copy link
Member

@OmarManzoor you might want to start a review, add all comments, and then submit your review rather than posting single comments ;) this would give everybody subscribed to the PR one notification for all your comments rather than a separate notification for each comment :)

@OmarManzoor
Copy link
Contributor

@OmarManzoor you might want to start a review, add all comments, and then submit your review rather than posting single comments ;) this would give everybody subscribed to the PR one notification for all your comments rather than a separate notification for each comment :)

Oh you are right. Thank you for pointing out. I did not realize this.

OmarManzoor
OmarManzoor approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Thank you for working on this.

@OmarManzoor
Copy link
Contributor

@lucyleeow Do you want to have a final look at this before merging?

@greyisbetter
Copy link
Contributor Author

@adrinjalali and @OmarManzoor, I think we have 2 approved reviews

@OmarManzoor OmarManzoor merged commit 150ff34 into scikit-learn:main Jul 17, 2023
@OmarManzoor
Copy link
Contributor

Thanks @greyisbetter

@greyisbetter greyisbetter deleted the add-example-sklearn-is-fitted branch July 17, 2023 09:36
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@greyisbetter @adrinjalali @punndcoder28
[MRG] DOC add __sklearn_is_fitted__ example (scikit-learn#26618)
ae17c77 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@greyisbetter @adrinjalali @glemaitre
[MRG] DOC add __sklearn_is_fitted__ example (scikit-learn#26618)
35d1b93 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@greyisbetter @adrinjalali @jeremiedbb
[MRG] DOC add __sklearn_is_fitted__ example (#26618)
05d3b7c 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@greyisbetter @adrinjalali @REDVM
[MRG] DOC add __sklearn_is_fitted__ example (scikit-learn#26618)
1e697f2 
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim left review comments

@lucyleeow lucyleeow lucyleeow left review comments

@adrinjalali adrinjalali adrinjalali approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
Documentation Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC add __sklearn_is_fitted__ and others to Developer guide
5 participants
@greyisbetter @adrinjalali @OmarManzoor @betatim @lucyleeow