Skip to content

[Notifier] support local development for sns by adding sslmode option #50879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

[Notifier] support local development for sns by adding sslmode option #50879

merged 1 commit into from
Aug 1, 2023

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Jul 4, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets none
License MIT
Doc PR symfony/symfony-docs#...

When developing locally with AWS -> localstack we have to communicate via HTTP similarly to the SQS Transport for Messenger component.

https://github.com/symfony/amazon-sqs-messenger/blob/6.3/Transport/Connection.php#L50C14-L50C14

@Ferror Ferror requested a review from OskarStark as a code owner July 4, 2023 19:45
@carsonbot carsonbot added this to the 6.4 milestone Jul 4, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@Ferror Ferror changed the title [Notifier] support local development for sns [Notifier] support local development for sns by adding sslmode option Jul 4, 2023
fabpot
fabpot requested changes Jul 30, 2023
View reviewed changes
src/Symfony/Component/Notifier/Bridge/AmazonSns/AmazonSnsTransportFactory.php Outdated
@@ -31,8 +31,10 @@ public function create(Dsn $dsn): AmazonSnsTransport

$host = 'default' === $dsn->getHost() ? null : $dsn->getHost();
$port = $dsn->getPort();
$sslmode = $dsn->getOption('sslmode', true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be consistent with SQS? It seems that we are using disable there to disable SSL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it has only disable/enable values which seems like a great usage of a simple boolean. Yea, let's keep it consistent.

@Ferror Ferror requested a review from fabpot July 31, 2023 14:12
@fabpot fabpot force-pushed the notifier-sns-sslmode branch from 3aea8aa to 92650d6 Compare August 1, 2023 05:58
@fabpot
Copy link
Member

fabpot commented Aug 1, 2023

Thank you @Ferror.

@fabpot fabpot mentioned this pull request Aug 1, 2023
Closed
@fabpot fabpot merged commit be8897b into symfony:6.4 Aug 1, 2023
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferror @carsonbot @fabpot